codeant-ai-for-open-source[bot] commented on code in PR #37516: URL: https://github.com/apache/superset/pull/37516#discussion_r3592129531
########## superset/common/chart_data_timing.py: ########## @@ -0,0 +1,803 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See the NOTICE file +# distributed with this work for additional information +# regarding copyright ownership. The ASF licenses this file +# to you under the Apache License, Version 2.0 (the +# "License"); you may not use this file except in compliance +# with the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, +# software distributed under the License is distributed on an +# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +# KIND, either express or implied. See the License for the +# specific language governing permissions and limitations +# under the License. +from __future__ import annotations + +import logging +import time +from collections.abc import Callable, Iterator, Mapping +from contextlib import contextmanager +from contextvars import ContextVar +from dataclasses import dataclass, field, replace +from enum import Enum +from typing import Any, Literal, TYPE_CHECKING + +from flask import current_app + +if TYPE_CHECKING: + from superset.common.query_context import QueryContext + +NANOSECONDS_PER_MILLISECOND = 1_000_000 +SOURCE_TRACE_VERSION = 2 +MAX_SOURCE_TRACE_DEPTH = 8 +MAX_SOURCE_TRACE_NODES = 64 Review Comment: **Suggestion:** Add explicit type annotations to the newly introduced module-level constants to satisfy the variable type-hint requirement. [custom_rule] **Severity Level:** Minor ๐งน <details> <summary><b>Why it matters? โญ </b></summary> These newly introduced module-level constants are plain assignments without explicit type hints, and they are trivially annotatable integer constants. This matches the Python type-hint rule. </details> <details> <summary><b>Rule source ๐ </b></summary> .cursor/rules/dev-standard.mdc (line 28) </details> [](https://app.codeant.ai/fix-in-ide?tool=cursor&prompt_id=b3f3f5b6718340349ff7b87904b2134d&service=github&base_url=https%3A%2F%2Fgithub.com&org=apache&repo=apache%2Fsuperset) [](https://app.codeant.ai/fix-in-ide?tool=vscode-claude&prompt_id=b3f3f5b6718340349ff7b87904b2134d&service=github&base_url=https%3A%2F%2Fgithub.com&org=apache&repo=apache%2Fsuperset) *(Use Cmd/Ctrl + Click for best experience)* <details> <summary><b>Prompt for AI Agent ๐ค </b></summary> ```mdx This is a comment left during a code review. **Path:** superset/common/chart_data_timing.py **Line:** 33:36 **Comment:** *Custom Rule: Add explicit type annotations to the newly introduced module-level constants to satisfy the variable type-hint requirement. Validate the correctness of the flagged issue. If correct, How can I resolve this? If you propose a fix, implement it and please make it concise. Once fix is implemented, also check other comments on the same PR, and ask user if the user wants to fix the rest of the comments as well. if said yes, then fetch all the comments validate the correctness and implement a minimal fix ``` </details> <a href='https://app.codeant.ai/feedback?pr_url=https%3A%2F%2Fgithub.com%2Fapache%2Fsuperset%2Fpull%2F37516&comment_hash=16040eec5d2ae2e0e8a09673bf853cbd15c4ac9e78c2bc0d6bf6288db2c9abb1&reaction=like'>๐</a> | <a href='https://app.codeant.ai/feedback?pr_url=https%3A%2F%2Fgithub.com%2Fapache%2Fsuperset%2Fpull%2F37516&comment_hash=16040eec5d2ae2e0e8a09673bf853cbd15c4ac9e78c2bc0d6bf6288db2c9abb1&reaction=dislike'>๐</a> ########## superset/common/utils/query_cache_manager.py: ########## @@ -69,12 +75,14 @@ def __init__( cache_value: dict[str, Any] | None = None, sql_rowcount: int | None = None, queried_dttm: str | None = None, + source_trace: tuple[SourceTiming, ...] | None = None, ) -> None: - self.df = df + self.df = DataFrame() if df is None else df Review Comment: **Suggestion:** Add an explicit instance-attribute type annotation for this newly introduced field assignment to keep attribute typing consistent and statically checkable. [custom_rule] **Severity Level:** Minor ๐งน <details> <summary><b>Why it matters? โญ </b></summary> The new instance attribute `self.df` is assigned in `__init__` without an explicit type annotation, and it is a field that can be annotated. This matches the Python type-hint requirement for newly introduced or modified code. </details> <details> <summary><b>Rule source ๐ </b></summary> .cursor/rules/dev-standard.mdc (line 28) </details> [](https://app.codeant.ai/fix-in-ide?tool=cursor&prompt_id=75992b23e5474dfa997b40f84d89a6ae&service=github&base_url=https%3A%2F%2Fgithub.com&org=apache&repo=apache%2Fsuperset) [](https://app.codeant.ai/fix-in-ide?tool=vscode-claude&prompt_id=75992b23e5474dfa997b40f84d89a6ae&service=github&base_url=https%3A%2F%2Fgithub.com&org=apache&repo=apache%2Fsuperset) *(Use Cmd/Ctrl + Click for best experience)* <details> <summary><b>Prompt for AI Agent ๐ค </b></summary> ```mdx This is a comment left during a code review. **Path:** superset/common/utils/query_cache_manager.py **Line:** 80:80 **Comment:** *Custom Rule: Add an explicit instance-attribute type annotation for this newly introduced field assignment to keep attribute typing consistent and statically checkable. Validate the correctness of the flagged issue. If correct, How can I resolve this? If you propose a fix, implement it and please make it concise. Once fix is implemented, also check other comments on the same PR, and ask user if the user wants to fix the rest of the comments as well. if said yes, then fetch all the comments validate the correctness and implement a minimal fix ``` </details> <a href='https://app.codeant.ai/feedback?pr_url=https%3A%2F%2Fgithub.com%2Fapache%2Fsuperset%2Fpull%2F37516&comment_hash=14d62ee39885bd94ea79f26f72e880ae6c13bac2e059c8ce3786ff05db0ff078&reaction=like'>๐</a> | <a href='https://app.codeant.ai/feedback?pr_url=https%3A%2F%2Fgithub.com%2Fapache%2Fsuperset%2Fpull%2F37516&comment_hash=14d62ee39885bd94ea79f26f72e880ae6c13bac2e059c8ce3786ff05db0ff078&reaction=dislike'>๐</a> ########## superset/connectors/sqla/models.py: ########## @@ -2186,7 +2187,10 @@ class and any keys added via `ExtraCache`. filtered_query_obj = { k: v for k, v in query_obj.items() if k in SQLA_QUERY_KEYS } - sqla_query = self.get_sqla_query(**cast(Any, filtered_query_obj)) + sqla_query = self.get_sqla_query( + **cast(Any, filtered_query_obj), + defer_source_queries=True, + ) Review Comment: **Suggestion:** Add an explicit type annotation for the local `sqla_query` variable to satisfy the type-hint requirement for relevant new variables. [custom_rule] **Severity Level:** Minor ๐งน <details> <summary><b>Why it matters? โญ </b></summary> This is a new local variable in modified Python code, and it is assigned without any type annotation even though the value is used as a query object and can be annotated. That matches the rule requiring type hints on relevant variables. </details> <details> <summary><b>Rule source ๐ </b></summary> .cursor/rules/dev-standard.mdc (line 28) </details> [](https://app.codeant.ai/fix-in-ide?tool=cursor&prompt_id=0b0325e63f874f07a435bd94512d0133&service=github&base_url=https%3A%2F%2Fgithub.com&org=apache&repo=apache%2Fsuperset) [](https://app.codeant.ai/fix-in-ide?tool=vscode-claude&prompt_id=0b0325e63f874f07a435bd94512d0133&service=github&base_url=https%3A%2F%2Fgithub.com&org=apache&repo=apache%2Fsuperset) *(Use Cmd/Ctrl + Click for best experience)* <details> <summary><b>Prompt for AI Agent ๐ค </b></summary> ```mdx This is a comment left during a code review. **Path:** superset/connectors/sqla/models.py **Line:** 2190:2193 **Comment:** *Custom Rule: Add an explicit type annotation for the local `sqla_query` variable to satisfy the type-hint requirement for relevant new variables. Validate the correctness of the flagged issue. If correct, How can I resolve this? If you propose a fix, implement it and please make it concise. Once fix is implemented, also check other comments on the same PR, and ask user if the user wants to fix the rest of the comments as well. if said yes, then fetch all the comments validate the correctness and implement a minimal fix ``` </details> <a href='https://app.codeant.ai/feedback?pr_url=https%3A%2F%2Fgithub.com%2Fapache%2Fsuperset%2Fpull%2F37516&comment_hash=683804553c6872ad942ab34f29702713acb97e321a7b31322f6d60c81c102821&reaction=like'>๐</a> | <a href='https://app.codeant.ai/feedback?pr_url=https%3A%2F%2Fgithub.com%2Fapache%2Fsuperset%2Fpull%2F37516&comment_hash=683804553c6872ad942ab34f29702713acb97e321a7b31322f6d60c81c102821&reaction=dislike'>๐</a> -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
