rusackas commented on PR #41635: URL: https://github.com/apache/superset/pull/41635#issuecomment-5018538402
The PR description mentions an `OAUTH_SKIP_PROVIDER_SELECTION` flag, but I don't see it referenced anywhere in the diff, this just always skips the selection screen for single-provider setups unconditionally. Was the flag meant to gate this, since it's a behavior change for anyone currently relying on that screen? Also worth noting `unit-tests` is failing on this branch, looks like the new tests are leaving `oauth_remotes` mocked in a way that breaks unrelated security tests running after them. Holler if I can help further. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
