rusackas commented on PR #36076: URL: https://github.com/apache/superset/pull/36076#issuecomment-5024980808
@ysinghc the CI failure here is real. `master` picked up a test asserting arbitrary valid JSON passes `ChartPutSchema.query_context`, and the stricter check breaks it. As mentioned above, charts already saved with an incomplete `query_context` would start 400ing on save, so I still think the fix belongs on the generation side rather than save-time validation. Happy to re-review if we can settle that layer question first. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
