rusackas commented on PR #42328: URL: https://github.com/apache/superset/pull/42328#issuecomment-5064850734
Notes-to-self on what's deliberately NOT covered here, so we can follow up later. A few viz types still have no example chart, and keep their old thumbnails for now: - [ ] `pop_kpi` and `ag-grid-table` are feature-flag-gated (`ChartPluginsExperimental` / `AgGridTableEnabled`), so their plugins aren't registered on default deployments and example charts would just render as errors there. Worth revisiting if/when those flags graduate. The capture tool already knows both are markup-only renders. - [ ] `deck_geojson` needs an example dataset with a geojson column... none of the current example data has one, so this needs a (small) new data file. - [ ] `deck_multi` stores its sub-layers as numeric slice ids in `deck_slices`, which the YAML importer can't remap, so a portable example needs either an importer feature or a python loader step. - [ ] `cartodiagram` embeds a serialized sub-chart config (`selected_chart`), which needs some careful hand-crafting. Also, the gallery diversification piece. Several plugins register multi-image example galleries, and so far only the thumbnails (plus the new Line percent-change example) are live-captured. To regenerate ALL the gallery art from live charts (and let those charts double as regression fixtures later), we'd want a variant example chart modeling each config: Pie has 4 gallery images, Table / Waterfall / Bar / Heatmap / ag-grid have 3 each, and world map, word cloud, rose, point cluster map, parallel coordinates, handlebars, treemap and step have 2 each. Once a variant exists as an example chart, the crawler's `EXTRA_CAPTURES` list maps it to its gallery image slot. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
