rusackas commented on PR #42328: URL: https://github.com/apache/superset/pull/42328#issuecomment-5066529060
Round two of thumbnails is up: everything recaptured on the white/dark card background (the gray was an artifact of explore's standalone page, not how dashboards render), with purpose-built example charts for most of the review feedback. The gauge got its colored ranges and needle back, mixed shows dual-axis bars and a line, the donut keeps its labels, the calendar captures mid-tooltip, deck hex is back to the downtown 3D columns (autozoom was overriding the stored viewport), and the generic time-series thumbnail shows forecast bands again. Two real fixes fell out of this: the rose legend/label text was unreadable in dark theme (nvd3-fork leaves SVG text on the default black fill) and that fix is on the main PR branch as 45fd4117a9. And the point cluster map was never broken, the example just queried a spatially-skewed 5000-row slice that put every cluster off-viewport. Leftovers for later, on top of the earlier list: - [ ] Waterfall is all-green: monthly sales only ever go up, so there are no red decrease bars. Needs a delta-friendly metric or dataset to show the up/down identity. - [ ] Tree chart keeps its current example; none of the example datasets have a real parent/child hierarchy like whatever the old thumbnail used. - [ ] Horizon still has a lot of empty space... not sure what makes that one awesome yet. - [ ] deck.gl Heatmap is fine but not as striking as the old art; dataset limits. - [ ] Rose rings don't visibly grow year over year on wb population; a dataset with more period-to-period growth would sell it better. - [ ] The forecast thumbnail came from a locally-tweaked chart since prophet is an optional dependency; the shipped example stays forecast-free so default deployments don't error. - [ ] The handlebars showcase tab idea (keep the logo, add a Misc tab of CSS-heavy handlebars examples). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
