aminghadersohi commented on PR #42306: URL: https://github.com/apache/superset/pull/42306#issuecomment-5066906436
@bito-code-review the underlying claim here is the same one raised in the inline review thread on `superset/utils/log.py:200` — I verified it empirically against this repo's pinned SQLAlchemy/Werkzeug/Flask-Login versions and it doesn't hold up: `sqlalchemy.inspect()` already unwraps a `LocalProxy` correctly (via an attribute-based `_sa_instance_state` lookup that `LocalProxy.__getattr__` forwards to the wrapped object), for both mapped and unmapped users. Full reproduction and explanation here: https://github.com/apache/superset/pull/42306#discussion_r3643420727 Manually unwrapping with `_get_current_object()` first would be a no-op given that behavior, so I'm not applying the suggested change unless someone has a concrete counter-example. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
