bito-code-review[bot] commented on code in PR #42306:
URL: https://github.com/apache/superset/pull/42306#discussion_r3643636676
##########
tests/integration_tests/event_logger_tests.py:
##########
@@ -231,6 +232,88 @@ def log(
assert logger.records[0]["user_id"] == None # noqa: E711
+ def test_log_with_context_guest_user_skips_warning(self):
+ """Guest/anonymous users are never DB-mapped; adding them to the
+ session is expected to be a no-op, not a warning-worthy failure."""
+
+ class DummyEventLogger(AbstractEventLogger):
Review Comment:
<div>
<div id="suggestion">
<div id="issue"><b>Duplicate DummyEventLogger class definition</b></div>
<div id="fix">
This file contains syntactic duplication of the DummyEventLogger class
definition, which appears at multiple locations: lines 113-134, 152-173,
202-223, 239-260, and 279-298. Consider extracting this common test utility to
a shared fixtures module to reduce duplication and improve maintainability.
</div>
</div>
<small><i>Code Review Run #dbdaca</i></small>
</div>
---
Should Bito avoid suggestions like this for future reviews? (<a
href=https://alpha.bito.ai/home/ai-agents/review-rules>Manage Rules</a>)
- [ ] Yes, avoid them
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
