Copilot commented on code in PR #42078:
URL: https://github.com/apache/superset/pull/42078#discussion_r3647301026
##########
superset-frontend/packages/superset-ui-core/src/components/ActionButton/index.tsx:
##########
@@ -52,14 +67,17 @@ export const ActionButton = ({
fill: ${theme.colorPrimary};
}
}
+ &.disabled {
+ color: ${theme.colorTextDisabled};
+ cursor: not-allowed;
+ }
Review Comment:
When ActionButton is rendered in the disabled state, the hover styling still
applies to the icon paths, so disabled actions can visually highlight on hover
even though they can’t be activated. This is confusing feedback for a disabled
control.
##########
superset-frontend/src/explore/components/controls/ColumnConfigControl/ColumnConfigControl.tsx:
##########
@@ -167,10 +166,15 @@ export default function ColumnConfigControl<T extends
ColumnConfig>({
/>
))}
{needShowMoreButton && (
- <div
- role="button"
+ <button
+ type="button"
tabIndex={-1}
css={{
Review Comment:
This control is now a real <button>, but it still has tabIndex={-1}, which
removes it from the keyboard tab order. Users who rely on keyboard navigation
won’t be able to reach the “Show all/less columns” toggle.
##########
superset-frontend/src/components/CopyToClipboard/CopyToClipboard.stories.tsx:
##########
@@ -31,7 +31,7 @@ export const InteractiveCopyToClipboard = ({ copyNode,
...rest }: any) => {
if (copyNode === 'Icon') {
node = <Icons.CopyOutlined />;
} else if (copyNode === 'Text') {
- node = <span role="button">Copy</span>;
+ node = <button type="button">Copy</button>;
}
Review Comment:
The Storybook “Text” variant sets copyNode to a <button>, but
CopyToClipboard now wraps copyNode in its own <button>. This creates invalid
nested buttons in the rendered story and can cause unexpected
behavior/accessibility issues.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
