rusackas commented on PR #42078: URL: https://github.com/apache/superset/pull/42078#issuecomment-5082318611
Thanks for the deep review, @aminghadersohi. Dug into the keyboard-activation test gap: `userEvent` is pinned to v12 here, which has no `.keyboard()`, and jsdom doesn't synthesize a click from a raw keydown on a native `<button>` either (same limitation `CopyToClipboard.test.tsx` already works around by testing components with their own manual `onKeyDown`). So there's no meaningful test to write here beyond trusting native button semantics. Leaving `DrillBySubmenu`'s `aria-expanded` gap alone since you already flagged it as pre-existing, not something this pass touched. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
