rusackas commented on code in PR #42309:
URL: https://github.com/apache/superset/pull/42309#discussion_r3649901231
##########
superset-frontend/plugins/legacy-plugin-chart-country-map/scripts/Country Map
GeoJSON Generator.ipynb:
##########
@@ -79,7 +79,7 @@
"source": [
"## Download Data\n",
"\n",
- "Download datasets (_Admin 0 - Countries_ in
[1:10](https://www.naturalearthdata.com/downloads/10m-cultural-vectors/), and
_Admin 1 – States, Provinces_ in 1:10 and
[1:50](https://www.naturalearthdata.com/downloads/50m-cultural-vectors/)) from
Natural Earch Data:"
+ "Download datasets (_Admin 0 - Countries_ in
[1:10](https://www.naturalearthdata.com/downloads/10m-cultural-vectors/), and
_Admin 1 \u2013 States, Provinces_ in 1:10 and
[1:50](https://www.naturalearthdata.com/downloads/50m-cultural-vectors/)) from
Natural Earch Data:"
Review Comment:
Good catch, fixed!
##########
superset-frontend/plugins/legacy-plugin-chart-country-map/src/countries.ts:
##########
@@ -103,6 +103,7 @@ import iran from './countries/iran.geojson';
import israel from './countries/israel.geojson';
import italy from './countries/italy.geojson';
import italy_regions from './countries/italy_regions.geojson';
+import italy_regions_and_autonomous_provinces from
'./countries/italy_regions_and_autonomous_provinces.geojson';
Review Comment:
The geojson file's actually already in this branch,
`src/countries/italy_regions_and_autonomous_provinces.geojson` (108KB, binary,
so it might not show up wherever Codeant's diffing from). Nothing missing here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
