rusackas commented on code in PR #42309:
URL: https://github.com/apache/superset/pull/42309#discussion_r3679227090
##########
superset-frontend/plugins/legacy-plugin-chart-country-map/scripts/Country Map
GeoJSON Generator.ipynb:
##########
@@ -3794,6 +3795,35 @@
"not speed_run and italy_regions.plot(figsize=(10, 7), **plot_styles)"
]
},
+ {
+ "cell_type": "markdown",
+ "metadata": {},
+ "source": [
+ "#### Italy Regions and Autonomous Provinces"
+ ]
+ },
+ {
+ "cell_type": "code",
+ "execution_count": null,
+ "metadata": {},
+ "outputs": [],
+ "source": [
+ "trento_and_bozen = df[(df.admin == 'Italy') &
(df.iso_3166_2.isin(['IT-TN', 'IT-BZ']))][['geometry','iso_3166_2','name']]\n",
+ "\n",
+ "italy_regions_and_autonomous_provinces = pd.concat([italy_regions,
trento_and_bozen])\n",
+ "\n",
+ "italy_regions_and_autonomous_provinces =
italy_regions_and_autonomous_provinces[italy_regions_and_autonomous_provinces['iso_3166_2']
!= 'IT-32']"
Review Comment:
This isn't a removal, `italy_regions` (with `IT-32` etc.) stays exactly
as-is; `italy_regions_and_autonomous_provinces` is a brand new, separate map
option. Existing charts keep using the old map/codes untouched unless someone
explicitly switches to the new one.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
