bito-code-review[bot] commented on code in PR #42357:
URL: https://github.com/apache/superset/pull/42357#discussion_r3653274153
##########
tests/unit_tests/common/test_query_context_processor.py:
##########
@@ -2256,3 +2256,106 @@ def fake_get_query_result(sub_query: QueryObject) ->
QueryResult:
# ...and the requested offset is applied exactly once, to the combined
# result: 2 + 1 = 3 total rows in, minus an offset of 1 = 2 rows out.
assert len(result.df) == 2
+
+
+def test_relative_offset_preserves_inner_bounds(
+ processor: QueryContextProcessor,
+) -> None:
+ """
+ Regression test for #40501: Relative time comparison offset should
+ preserve inner bounds as the original (unshifted) period, not the shifted
one.
+
+ When comparing 2026-05-01 : 2026-05-28 with offset "365 days ago":
+ - inner_from_dttm should be 2026-05-01 (original), NOT 2025-05-01 (shifted)
+ - inner_to_dttm should be 2026-05-28 (original), NOT 2025-05-28 (shifted)
+ """
+ from superset.common.query_object import QueryObject
+ from superset.models.helpers import ExploreMixin
+
+ datasource: Any = processor._qc_datasource
+
+ for method in (
+ "processing_time_offsets",
+ "_align_offset_without_time_grain",
+ "_coalesce_offset_index",
+ ):
+ setattr(
+ datasource,
+ method,
+ getattr(ExploreMixin, method).__get__(datasource),
+ )
+
+ df = pd.DataFrame(
+ {
+ "__timestamp": pd.to_datetime(["2026-05-01", "2026-05-15",
"2026-05-28"]),
+ "sum__num": [100, 200, 300],
+ }
+ )
+
+ query_object = QueryObject(
+ datasource=MagicMock(),
+ granularity="ds",
+ columns=[],
+ metrics=["sum__num"],
+ is_timeseries=True,
+ time_offsets=["365 days ago"],
+ filters=[
+ {
+ "col": "ds",
+ "op": "TEMPORAL_RANGE",
+ "val": "2026-05-01 : 2026-05-28",
Review Comment:
<div>
<div id="suggestion">
<div id="issue"><b>Consolidate duplicated test helper code</b></div>
<div id="fix">
Code duplication identified in test file across multiple test functions. The
fake_query helper with captured list and mock DataFrame setup is repeated at
line ranges 1111-1124, 1205-1218, and 2306-2319. Consider extracting to a
module-level helper function to improve maintainability and reduce redundancy.
</div>
</div>
<small><i>Code Review Run #e66813</i></small>
</div>
---
Should Bito avoid suggestions like this for future reviews? (<a
href=https://alpha.bito.ai/home/ai-agents/review-rules>Manage Rules</a>)
- [ ] Yes, avoid them
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
