prathamesh04 commented on PR #42357: URL: https://github.com/apache/superset/pull/42357#issuecomment-5145641897
Hi @rusackas — thank you for the review and for pointing this out! Since that helper pattern already exists in the two pre-existing tests this one follows, I'd prefer to keep this PR scoped to the fix itself and leave the consolidation for a follow-up cleanup, if that's okay with you. Thanks again to @aminghadersohi for the thorough review and for the approval — really appreciate the help getting this across the finish line. The PR should be ready to merge whenever you're ready. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
