rusackas opened a new pull request, #42493:
URL: https://github.com/apache/superset/pull/42493

   ### SUMMARY
   Housekeeping ahead of 7.0: re-ran the Country Map GeoJSON Generator notebook 
(`npm run update-maps`) end to end against current Natural Earth data and the 
geopandas/shapely/pyogrio versions available here, so every country's map comes 
from the same generation pass instead of whatever was current whenever each one 
was last regenerated. No cell errors, and every country that existed before 
still exists after (nothing got dropped by the notebook's own 
single-subdivision purge).
   
   Most of the diff is small coordinate/vertex drift from the refreshed 
toolchain, not deliberate geometry edits. I didn't eyeball all 60 files 
individually, so flag anything that looks off.
   
   This also ports the Iran ISO 3166-2 fix from #42439 into the notebook itself 
(Alborz to IR-30, Razavi Khorasan to IR-09), since that PR only patched the 
checked-in geojson and this regen would've silently reverted it otherwise. Once 
#42439 merges, rebasing this branch should collapse that hunk to a no-op.
   
   ### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
   N/A, generated data only.
   
   ### TESTING INSTRUCTIONS
   `npm run update-maps` in `superset-frontend` and confirm the diff against 
this branch is empty.
   
   Or spot check a country map chart against a few countries and confirm 
nothing looks broken. For Iran specifically, `npm run test -- 
plugins/legacy-plugin-chart-country-map/test/countries/iran.test.ts` (from 
#42439) still passes.
   
   ### ADDITIONAL INFORMATION
   - [ ] Has associated issue:
   - [ ] Required feature flags:
   - [x] Changes UI
   - [ ] Includes DB Migration
   - [ ] Introduces new feature or API
   - [ ] Removes existing feature or API
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to