bxsx commented on code in PR #42494:
URL: https://github.com/apache/superset/pull/42494#discussion_r3661995170
##########
superset/reports/api.py:
##########
@@ -194,6 +195,7 @@ def ensure_alert_reports_enabled(self) ->
Optional[Response]:
"extra",
"force_screenshot",
"grace_period",
+ "include_cta",
Review Comment:
This mirrors the existing pattern for per-schedule settings:
force_screenshot, email_subject, and custom_width are likewise exposed via
show_columns/add_columns/edit_columns but not list_columns. The list view
doesn't render any of these, and both the Alerts & Reports modal and any
detail-oriented client fetch the full resource via the show endpoint. I've kept
the column lists consistent with the sibling fields — happy to add it if the
maintainers prefer, but that would arguably belong in a change covering all
per-schedule settings, not just this one.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
