bito-code-review[bot] commented on code in PR #42494:
URL: https://github.com/apache/superset/pull/42494#discussion_r3662006870
##########
docs/admin_docs/configuration/alerts-reports.mdx:
##########
@@ -28,6 +28,7 @@ Alerts and reports are disabled by default. To turn them on,
you'll need to chan
- Users can customize the email subject by including date code placeholders,
which will automatically be replaced with the corresponding UTC date when the
email is sent. To enable this functionality, activate the
`"DATE_FORMAT_IN_EMAIL_SUBJECT"` [feature
flag](/admin-docs/configuration/configuring-superset#feature-flags). This
enables date formatting in email subjects, preventing all reporting emails from
being grouped into the same thread (optional for the reporting feature).
- Use date codes from [strftime.org](https://strftime.org/) to create the
email subject.
- If no date code is provided, the original string will be used as the
email subject.
+- Each alert/report has an "Include a link back to Superset" option (enabled
by default) controlling whether the call-to-action link (its email text is
configurable via `EMAIL_REPORTS_CTA`) is included in email and Slack
notifications. Uncheck it when recipients should not receive a link to your
Superset host, e.g. for external audiences.
Review Comment:
<!-- Bito Reply -->
The clarification provided in the documentation update is appropriate. By
explicitly stating that the `EMAIL_REPORTS_CTA` configuration only affects
email notifications and that Slack notifications use a fixed string, the
potential for user confusion regarding the scope of this setting is resolved.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
