mikebridge commented on PR #41549: URL: https://github.com/apache/superset/pull/41549#issuecomment-5104665589
Ran a 7-lens local review panel (python / sqlalchemy / committer / preset / clean-code / DDD / tidy-first) before merge, given this PR hard-deletes data. Fixes in ac6890f1b3: - **Retention cutoff clock**: reverted to the naive-local clock `soft_delete()` uses for `deleted_at` (PR #33693 convention) — the naive-UTC cutoff introduced in 91e9a6930a shifted the window by the server's TZ offset (early purge west of UTC). Two lenses caught this independently against `helpers.py`. - **`embedded_dashboards` explicit delete** (7/7 lenses): the delete-orphan child carrying the public embed UUID leaked on FK-off SQLite; FK-off test extended. - **Suppression ordering**: commit moved outside `suppress_purge_association_versions` so the trim precedes Continuum's pending-statement execution; integration test pins zero association shadows with capture ON. - **Chunked IN() lists** in the orphan-transaction sweep (SQLite 999-bind limit; a long-history entity previously became permanently unpurgeable). - **`PurgeAuditLog` moved to `superset/models/`** so it registers with `Model.metadata` at app init — `alembic autogenerate` would otherwise propose dropping the table; composite index added to the model. - **Write-ahead audit now fails closed for the scheduled purge** (skip + retry next run) while force-purge proceeds with the operator present — resolves the design question flagged on the earlier bot threads; UPDATING.md updated (incl. `would_purge` upper-bound and force-purge-on-live notes). - Conditional-UPDATE finalize + locked reconcile scan (race closure), `click.UUID` validation on `--uuid`, and an index on `dashboard_slices_version(slice_id)`. Deferred with tickets to follow: IntegrityError-vs-policy-block anti-corruption + persisted block reason, blocked-entity audit-row growth/dedup, docs/ page. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
