mikebridge commented on PR #41549: URL: https://github.com/apache/superset/pull/41549#issuecomment-5116011822
Thanks for re-confirming — and yes, both are now tracked. There wasn't an overarching issue for them before, which was a fair thing to call out; there is now: - **CLI coverage** — the `set_window` / `show_window` / `force_purge` entry points. Filed with `CliRunner` as the suggested approach and the `force_purge` confirmation prompt called out as the part that actually matters, since it's the destructive operator-facing path. - **The M:N tripwire** — filed as the shape we discussed in July rather than just "add tests": a declarative per-entity purge registry (deletion validators, owned children and association tables, listener-equivalent cleanup, version-shadow ownership predicates, relationships deliberately preserved or treated as blockers), paired with contract tests that introspect mapped relationships and FKs and fail when a chart, dashboard, or dataset gains an owned or cascading relationship with no explicit purge policy. That second one is the interesting one, and I've noted on the ticket that it should land *before* the cascade grows to more entity types — the registry is much cheaper to introduce while the branch count is still small. The explicit cascade itself stays: it's what keeps purge consistent when SQLite FK enforcement is off, preserves ordinary deletion blockers, avoids traversing large relationship graphs, and handles Continuum transactions being shared across entities. The registry just moves the knowledge out of reviewers' heads and into something CI can fail on. Both are on the internal versioning epic. Happy to mirror the tripwire one as a GitHub issue if you'd rather it were visible to the community — it's arguably a general Superset maintainability concern rather than a Preset one, so say the word and I'll open it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
