bito-code-review[bot] commented on PR #42509:
URL: https://github.com/apache/superset/pull/42509#issuecomment-5107690115
<!-- Bito Reply -->
The suggestion to use an allowlist instead of an exclusion list is
appropriate. It improves maintainability by ensuring that new presets default
to the standard behavior, preventing accidental silent overrides. You can
implement this by checking if the preset is in the intended list of presets
that require the override.
**.github/workflows/docker.yml**
```
EXTRA_FLAGS="--build-arg INCLUDE_CHROMIUM=false --tag $IMAGE_TAG"
case "$BUILD_PRESET" in
dev|lean)
EXTRA_FLAGS="--build-arg PY_VER=3.11.14-slim-trixie
$EXTRA_FLAGS"
;;
esac
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
