rusackas commented on code in PR #42509:
URL: https://github.com/apache/superset/pull/42509#discussion_r3693977495
##########
.github/workflows/docker.yml:
##########
@@ -130,13 +130,25 @@ jobs:
# repeated --build-arg key, so appending PY_VER here overrides
# supersetbot's pin and keeps the build on the Dockerfile's own
# supported Python version.
+ #
+ # The "py311"/"py312" presets exist specifically to pin a
+ # *different* PY_VER than "dev"/"lean" (that's the whole point of
+ # those two presets), so they're excluded from this override.
+ # Without this exclusion, the PY_VER above clobbers theirs too
+ # (same last-value-wins rule), making "py311"/"py312" silently
+ # build the exact same image as "lean".
+ EXTRA_FLAGS="--build-arg INCLUDE_CHROMIUM=false --tag $IMAGE_TAG"
+ if [ "$BUILD_PRESET" != "py311" ] && [ "$BUILD_PRESET" != "py312" ];
then
Review Comment:
Good catch, this workflow-only change doesn't trip the docker change
detector, and the PR matrix never runs py311/py312 anyway, so this had zero CI
signal. Pulled the flag logic into a script and added an always-on job that
verifies it for every preset on every PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
