mikebridge commented on PR #41549: URL: https://github.com/apache/superset/pull/41549#issuecomment-5131441931
Pushed one more commit (`2cdfe31`) closing two gaps a review pass found in the codeant fixes. Both are on the operator path; no change to the retention task, the migration, or the cascade semantics. **The ambiguity refusal had no escape hatch.** `ForcePurgeCommand` now refuses a UUID that matches rows in more than one table rather than guessing — but the message says "pass the entity type to disambiguate" and the CLI had no such option, nor a handler for the exception. The operator got a raw traceback, and got it *after* answering the irreversible confirmation prompt — the exact failure mode the `type=click.UUID` validation a few lines above was added to prevent. `force-purge` now takes `--type/-t` and reports the refusal as a clean `ClickException`. **The identity guard in `_purge_one` had no test.** Deleting the `entity_uuid(entity) != entity_uuid_value` check left the whole suite green, so nothing pinned the invariant that an audit row names the entity actually purged. Now covered. Each new test has a verified control: it fails against the pre-fix source and passes with the fix. Reverting the CLI to the bare `ForcePurgeCommand(str(uuid)).run()` fails both CLI tests; replacing the guard with a constant-false branch fails the identity test. @eschutho @rusackas — re-request below since this touches the CLI you'd already approved. Happy to split it into a follow-up PR instead if you'd rather not re-review; the tradeoff is that master would briefly ship a `force-purge` that can traceback on an ambiguous UUID. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
