SBIN2010 commented on PR #42053:
URL: https://github.com/apache/superset/pull/42053#issuecomment-5136301859
> The gradient fix and the color-util tests look great now, thanks! Two
things before I'm happy: the picker trigger lost its label — the tests had to
drop `getByLabelText('Color scheme')`, so the field isn't reachable by screen
readers anymore. Can we forward an `aria-label` to the `ColorPicker`? Taking a
look at that now...
Hi @rusackas !
I added `aria Label` to the `Color Picker` and update the related tests.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
