codeant-ai-for-open-source[bot] commented on code in PR #42053:
URL: https://github.com/apache/superset/pull/42053#discussion_r3690615406
##########
superset-frontend/plugins/plugin-chart-table/src/transformProps.ts:
##########
@@ -737,8 +737,15 @@ const transformProps = (
const basicColorFormatters =
comparisonColorEnabled && getBasicColorFormatter(baseQuery?.data, columns);
const columnColorFormatters =
- getColorFormatters(conditionalFormatting, passedData, theme) ??
- defaultColorFormatters;
+ getColorFormatters(
+ (conditionalFormatting || []).filter(
+ (config: ConditionalFormattingConfig) =>
+ config.colorScheme !== ColorSchemeEnum.Green &&
+ config.colorScheme !== ColorSchemeEnum.Red,
+ ),
+ passedData,
+ theme,
+ ) ?? defaultColorFormatters;
Review Comment:
**Suggestion:** When time comparison is enabled, `passedData` contains
transformed keys such as `Main ${column}`, `# ${column}`, and `△ ${column}`,
while conditional-formatting configurations still reference the original column
name. `getColorFormatters` therefore reads `row[config.column]` as `undefined`,
and the resulting formatters either never match or compute their ranges from
missing values. Use the original query data for formatter statistics, or remap
conditional-formatting columns to the comparison keys. [incorrect variable
usage]
<details>
<summary><b>Severity Level:</b> Major ⚠️</summary>
```mdx
- ❌ Time-comparison tables ignore configured conditional colors.
- ⚠️ Metric and percentage comparison columns lose rule-based gradients.
- ⚠️ Users see inconsistent formatting after enabling time comparison.
```
</details>
[](https://app.codeant.ai/fix-in-ide?tool=cursor&prompt_id=2a8465b544ce46d38af5e4022a77f2c3&service=github&base_url=https%3A%2F%2Fgithub.com&org=apache&repo=apache%2Fsuperset)
[](https://app.codeant.ai/fix-in-ide?tool=vscode-claude&prompt_id=2a8465b544ce46d38af5e4022a77f2c3&service=github&base_url=https%3A%2F%2Fgithub.com&org=apache&repo=apache%2Fsuperset)
*(Use Cmd/Ctrl + Click for best experience)*
<details>
<summary><b>Prompt for AI Agent 🤖 </b></summary>
```mdx
This is a comment left during a code review.
**Path:** superset-frontend/plugins/plugin-chart-table/src/transformProps.ts
**Line:** 740:748
**Comment:**
*Incorrect Variable Usage: When time comparison is enabled,
`passedData` contains transformed keys such as `Main ${column}`, `# ${column}`,
and `△ ${column}`, while conditional-formatting configurations still reference
the original column name. `getColorFormatters` therefore reads
`row[config.column]` as `undefined`, and the resulting formatters either never
match or compute their ranges from missing values. Use the original query data
for formatter statistics, or remap conditional-formatting columns to the
comparison keys.
Validate the correctness of the flagged issue. If correct, How can I resolve
this? If you propose a fix, implement it and please make it concise.
Once fix is implemented, also check other comments on the same PR, and ask
user if the user wants to fix the rest of the comments as well. if said yes,
then fetch all the comments validate the correctness and implement a minimal fix
```
</details>
<a
href='https://app.codeant.ai/feedback?pr_url=https%3A%2F%2Fgithub.com%2Fapache%2Fsuperset%2Fpull%2F42053&comment_hash=13328b168e2c4320b765c227c99d708e4fd569b438d44705a73deea1f630fc44&reaction=like'>👍</a>
| <a
href='https://app.codeant.ai/feedback?pr_url=https%3A%2F%2Fgithub.com%2Fapache%2Fsuperset%2Fpull%2F42053&comment_hash=13328b168e2c4320b765c227c99d708e4fd569b438d44705a73deea1f630fc44&reaction=dislike'>👎</a>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
