rusackas commented on code in PR #41551:
URL: https://github.com/apache/superset/pull/41551#discussion_r3706292706
##########
superset-frontend/src/dashboard/types.ts:
##########
@@ -123,6 +123,7 @@ export type DashboardState = {
isFiltersRefreshing: boolean;
hasUnsavedChanges: boolean;
dashboardIsSaving: boolean;
+ lastModifiedTime?: number;
Review Comment:
I think this one's a false positive. That `changed_on`/`lastModifiedTime`
type mismatch already exists on `master` in `hydrate.ts`, this PR just adds the
type declaration mirroring what `dashboardState.ts` already had. The new
consumer here only treats it as an opaque change-signal string, so nothing here
is actually broken by this PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
