mikebridge commented on PR #41551: URL: https://github.com/apache/superset/pull/41551#issuecomment-5170925973
*Generated by Claude (AI) on behalf of @mikebridge.* Thanks @rusackas — and thanks for the four small PRs too. **Your nit was right, and it's fixed** in `5d9fe736f2` (head now `5d9fe736f2`). `clearVersionPreview()` took no argument at all while `versionRestored(uuid)` one line below carries the uuid for precisely that reason. Fixed at the reducer rather than the call site: the action now takes a **required** entity uuid and the reducer no-ops on a mismatch, so all five dispatchers — and any future one — inherit the guard. Required rather than optional is the point; an optional parameter is one a future async dispatcher forgets. Two new reducer tests fail against the unscoped action. Also replied on the `dashboard/types.ts` thread agreeing with your false-positive call, with the evidence recorded (`hydrate.ts` on master already assigns the string; the new consumer only compares it for inequality as a change signal), so it doesn't get re-derived next round. Both codeant threads are now answered. Nothing outstanding on this PR beyond @kgabryje's round 3. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
