dominicl-proxora commented on code in PR #42753:
URL: https://github.com/apache/superset/pull/42753#discussion_r3711296269
##########
helm/superset/templates/_helpers.tpl:
##########
@@ -700,15 +703,28 @@ superset init
echo "Init job: Creating admin user and loading initial data..."
{{- if .Values.init.createAdmin }}
echo "Creating admin user (if not present)..."
-if superset fab list-users 2>/dev/null | grep -qF {{ printf "username:%s"
.Values.init.adminUser.username | squote }}; then
+{{- if $adminSecretSet }}
+ADMIN_USERNAME="$SUPERSET_ADMIN_USERNAME"
+ADMIN_FIRSTNAME="$SUPERSET_ADMIN_FIRSTNAME"
+ADMIN_LASTNAME="$SUPERSET_ADMIN_LASTNAME"
+ADMIN_EMAIL="$SUPERSET_ADMIN_EMAIL"
+ADMIN_PASSWORD="$SUPERSET_ADMIN_PASSWORD"
+{{- else }}
+ADMIN_USERNAME={{ .Values.init.adminUser.username | quote }}
+ADMIN_FIRSTNAME={{ .Values.init.adminUser.firstname | quote }}
+ADMIN_LASTNAME={{ .Values.init.adminUser.lastname | quote }}
+ADMIN_EMAIL={{ .Values.init.adminUser.email | quote }}
+ADMIN_PASSWORD={{ .Values.init.adminUser.password | quote }}
+{{- end }}
+if superset fab list-users 2>/dev/null | grep -qF
'username:'"${ADMIN_USERNAME}"; then
echo "Admin user already exists, skipping."
else
superset fab create-admin \
- --username {{ .Values.init.adminUser.username | squote }} \
- --firstname {{ .Values.init.adminUser.firstname | squote }} \
- --lastname {{ .Values.init.adminUser.lastname | squote }} \
- --email {{ .Values.init.adminUser.email | squote }} \
- --password {{ .Values.init.adminUser.password | squote }}
+ --username "${ADMIN_USERNAME}" \
+ --firstname "${ADMIN_FIRSTNAME}" \
+ --lastname "${ADMIN_LASTNAME}" \
+ --email "${ADMIN_EMAIL}" \
+ --password "${ADMIN_PASSWORD}"
fi
Review Comment:
list-users | grep existed before
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
