hainenber commented on code in PR #42753:
URL: https://github.com/apache/superset/pull/42753#discussion_r3717459947


##########
helm/superset/values.yaml:
##########
@@ -1163,6 +1163,17 @@ init:
     lastname: Admin
     email: [email protected]
     password: admin
+    # -- Name of an existing Kubernetes Secret that holds the admin user 
credentials.
+    # If set, username, firstname, lastname, email, and password are read from 
this secret
+    # instead of from the values above. The secret keys are configurable via 
`secretKeys`.
+    existingSecret: ""
+    # -- Keys inside the existing secret that hold admin user fields.
+    secretKeys:

Review Comment:
   IMO, the existingSecret above can be nested into `secretKeys` for better 
org. `existingSecret` sounds generic enough to conflict with other future 
possible changes.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to