rusackas commented on code in PR #42559:
URL: https://github.com/apache/superset/pull/42559#discussion_r3717443082
##########
superset-frontend/plugins/plugin-chart-echarts/src/utils/eventHandlers.ts:
##########
@@ -46,6 +46,9 @@ const getCrossFilterDataMask =
labelMap: Record<string, string[]>,
) =>
(value: string) => {
+ if (!labelMap[value]) {
+ return undefined;
+ }
Review Comment:
Went ahead and pushed this (558f800): the guard now only short-circuits when
the value isn't already selected, so a stale/unknown selected value can still
be deselected by clicking it. Added a test for that case in
eventHandlers.test.ts.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
