sadpandajoe commented on code in PR #42573: URL: https://github.com/apache/superset/pull/42573#discussion_r3726203172
########## superset-frontend/plugins/plugin-chart-table/src/DataTable/utils/getScrollBarSize.ts: ########## @@ -16,6 +16,11 @@ * specific language governing permissions and limitations * under the License. */ +// Width/height of the custom `::-webkit-scrollbar` applied to the sticky +// body and header sizer in useSticky.tsx. Shared here so the measured +// scrollbar size always matches what actually renders. +export const CUSTOM_SCROLLBAR_SIZE = 8; Review Comment: Good catch — fixed in 58a89eb79. Split `getScrollBarSize()` back to measuring the plain native scrollbar (used by `TableChart.tsx`'s resize-twitch guard), and added a separate `getCustomScrollBarSize()` that measures with the custom `::-webkit-scrollbar` styling applied, used only by `useSticky.tsx`. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
