aminghadersohi commented on PR #42490: URL: https://github.com/apache/superset/pull/42490#issuecomment-5201417540
Reviewed the latest post-rebase bot feedback carefully. The two filtered "Missing Alias Resolution Config" findings on `HandlebarsChartConfig` and `BigNumberChartConfig` do not require a code change: - both classes retain their existing `ConfigDict(extra="ignore")`; this PR only changes their base class so all chart configs share `temporal_column` validation - neither class declares aliased fields that require `populate_by_name` - aliased nested fields remain on `ColumnRef`, which still has `ConfigDict(extra="ignore", populate_by_name=True)` after the conflict resolution - the affected chart suites pass (`60 passed`) and changed-file mypy/ruff/pylint hooks pass I also fetched the latest `apache/superset:master` and reran the rebase check; the PR branch is already fully up to date (`0` commits behind), conflict-free, and GitHub reports it mergeable. No duplicate replies were added to previously resolved threads. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
