sadpandajoe opened a new pull request, #42867:
URL: https://github.com/apache/superset/pull/42867

   ### SUMMARY
   Two small E2E follow-ups discovered while working on the edit-mode 
Playwright migration (#41438), which had already merged before these were 
pushed:
   
   1. **Stop recycling the single gunicorn worker mid-run.** The E2E backend 
runs with `--workers 1` alongside `--max-requests 500 --max-requests-jitter 
50`. With one worker there is nothing to roll over to, so every recycle takes 
the whole backend offline: gunicorn drains for the full 30s graceful timeout 
(browser keep-alive connections hold it open), then the replacement worker 
spends ~5s booting. A Playwright run issues roughly 3800 requests over ~8 
minutes, so the cap fired seven times, producing seven ~35s outages — visible 
as flaky tests (retried past a hung navigation) rather than as an infra 
failure. Removing the recycle removes the outage; there's no leak evidence over 
an 8-minute process to justify keeping it.
   2. **Give `mixed-chart-dashboard-filters.spec.ts` the slow-test budget.** 
Every sibling dashboard spec that builds its fixtures over the API 
(clear-all-filters, gauge-interval, dashboard-controls) raises its timeout to 
`TIMEOUT.SLOW_TEST`. This one didn't, despite doing four API round-trips before 
a full dashboard load with a preselected native filter.
   
   ### TESTING INSTRUCTIONS
   - CI: `playwright-tests` / `playwright-tests-required` should show fewer/no 
flaky retries tied to worker-recycle windows.
   - `mixed-chart-dashboard-filters.spec.ts` runs under its own budget instead 
of the 30s default.
   
   ### ADDITIONAL INFORMATION
   - [ ] Has associated issue:
   - [ ] Required feature flags:
   - [ ] Changes UI
   - [ ] Includes DB Migration
   - [ ] Introduces new feature or API
   - [ ] Removes existing feature or API


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to