codeant-ai-for-open-source[bot] commented on code in PR #42867:
URL: https://github.com/apache/superset/pull/42867#discussion_r3737521776
##########
superset-frontend/playwright/tests/dashboard/mixed-chart-dashboard-filters.spec.ts:
##########
@@ -54,6 +55,11 @@ const FILTER_VALUE = 'boy';
testWithAssets(
'Mixed chart applies dashboard filter to both queries (#29519)',
async ({ page, testAssets }) => {
+ // Four API round-trips of setup precede a full dashboard load with a
+ // preselected native filter, matching the other dashboard specs that build
+ // their fixtures over the API rather than importing them.
+ testWithAssets.setTimeout(TIMEOUT.SLOW_TEST);
Review Comment:
**Suggestion:** Raising the overall test timeout does not extend the
independent timeout used by `DashboardPage.waitForChartsToLoad()`, which
defaults to `TIMEOUT.API_RESPONSE` (15 seconds). On a slow or cold CI runner,
the dashboard can still fail during chart mounting/loading after 15 seconds
even though the test now has a 60-second budget. Pass an appropriate longer
timeout to the dashboard wait, or otherwise align the nested waits with the
slow-test budget. [timeout and test-lifecycle behavior]
<details>
<summary><b>Severity Level:</b> Major ⚠️</summary>
```mdx
- ❌ Mixed-chart dashboard test can fail before its 60-second budget expires.
- ⚠️ Slow CI chart rendering causes avoidable flaky retries.
- ⚠️ Filter-propagation regression coverage becomes unreliable on cold
runners.
```
</details>
[](https://app.codeant.ai/fix-in-ide?tool=cursor&prompt_id=76e6cd09c5b54af1adccfc444e2e61a2&service=github&base_url=https%3A%2F%2Fgithub.com&org=apache&repo=apache%2Fsuperset)
[](https://app.codeant.ai/fix-in-ide?tool=vscode-claude&prompt_id=76e6cd09c5b54af1adccfc444e2e61a2&service=github&base_url=https%3A%2F%2Fgithub.com&org=apache&repo=apache%2Fsuperset)
*(Use Cmd/Ctrl + Click for best experience)*
<details>
<summary><b>Prompt for AI Agent 🤖 </b></summary>
```mdx
This is a comment left during a code review.
**Path:**
superset-frontend/playwright/tests/dashboard/mixed-chart-dashboard-filters.spec.ts
**Line:** 61:61
**Comment:**
*Timeout And Test Lifecycle Behavior: Raising the overall test timeout
does not extend the independent timeout used by
`DashboardPage.waitForChartsToLoad()`, which defaults to `TIMEOUT.API_RESPONSE`
(15 seconds). On a slow or cold CI runner, the dashboard can still fail during
chart mounting/loading after 15 seconds even though the test now has a
60-second budget. Pass an appropriate longer timeout to the dashboard wait, or
otherwise align the nested waits with the slow-test budget.
Validate the correctness of the flagged issue. If correct, How can I resolve
this? If you propose a fix, implement it and please make it concise.
Once fix is implemented, also check other comments on the same PR, and ask
user if the user wants to fix the rest of the comments as well. if said yes,
then fetch all the comments validate the correctness and implement a minimal fix
```
</details>
<a
href='https://app.codeant.ai/feedback?pr_url=https%3A%2F%2Fgithub.com%2Fapache%2Fsuperset%2Fpull%2F42867&comment_hash=d3b5f5bb7262fb79eecd39c3fb8035f064dc02f71d6313abe0a709777b172cb9&reaction=like'>👍</a>
| <a
href='https://app.codeant.ai/feedback?pr_url=https%3A%2F%2Fgithub.com%2Fapache%2Fsuperset%2Fpull%2F42867&comment_hash=d3b5f5bb7262fb79eecd39c3fb8035f064dc02f71d6313abe0a709777b172cb9&reaction=dislike'>👎</a>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
