bito-code-review[bot] commented on code in PR #42328:
URL: https://github.com/apache/superset/pull/42328#discussion_r3732861946
##########
superset/examples/deckgl_demo/charts/Deck.gl_Hexagons.yaml:
##########
@@ -48,8 +49,8 @@ params:
bearing: -2.3984797349335167
latitude: 37.789795085160335
longitude: -122.40632230075536
- pitch: 54.08961642447763
- zoom: 13.835465702403654
+ pitch: 50
+ zoom: 13.6
Review Comment:
<div>
<div id="suggestion">
<div id="issue"><b>Viewport values diverge from storybook</b></div>
<div id="fix">
The viewport values for `pitch` and `zoom` have been rounded to cleaner
values (50, 13.6) but diverge from the canonical defaults shown in
`Hex.stories.tsx` which uses the full-precision values (54.08961642447763,
13.835465702403654). Demo examples should match storybook defaults to avoid
confusing users who reference both.
</div>
</div>
<small><i>Code Review Run #8c488a</i></small>
</div>
---
Should Bito avoid suggestions like this for future reviews? (<a
href=https://alpha.bito.ai/home/ai-agents/review-rules>Manage Rules</a>)
- [ ] Yes, avoid them
##########
superset/examples/misc_charts/charts/Sales_Calendar_Heatmap.yaml:
##########
@@ -0,0 +1,47 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership. The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied. See the License for the
+# specific language governing permissions and limitations
+# under the License.
+cache_timeout: null
+certification_details: null
+certified_by: null
+dataset_uuid: e8623bb9-5e00-f531-506a-19607f5f8005
+description: Daily sales intensity across a year, one cell per day.
+params:
+ cell_padding: 2
+ cell_radius: 0
+ cell_size: 12
+ domain_granularity: month
+ granularity_sqla: order_date
+ metrics:
+ - aggregate: SUM
+ column:
+ column_name: sales
+ expressionType: SIMPLE
+ label: SUM(sales)
+ optionName: metric_sales_calendar
+ show_legend: true
+ show_metric_name: true
+ show_values: false
+ steps: 10
+ subdomain_granularity: day
+ time_range: '2004-01-01 : 2005-01-01'
+ viz_type: cal_heatmap
+ x_axis_time_format: smart_date
+query_context: null
+slice_name: Sales Calendar Heatmap
+uuid: ef13dcad-c918-4367-ab17-a31d56e770e0
+version: 1.0.0
+viz_type: cal_heatmap
Review Comment:
<div>
<div id="suggestion">
<div id="issue"><b>Duplicate viz_type field</b></div>
<div id="fix">
The `viz_type` is specified twice: inside `params` at line 41 and as a
top-level key at line 47. All 40 other chart YAML files in
`superset/examples/misc_charts/charts/` use exactly one top-level `viz_type`
entry. Remove the one inside `params` to match established conventions and
avoid potential serialization or parsing ambiguity.
</div>
</div>
<small><i>Code Review Run #8c488a</i></small>
</div>
---
Should Bito avoid suggestions like this for future reviews? (<a
href=https://alpha.bito.ai/home/ai-agents/review-rules>Manage Rules</a>)
- [ ] Yes, avoid them
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
