bito-code-review[bot] commented on code in PR #42328: URL: https://github.com/apache/superset/pull/42328#discussion_r3733777392
########## superset/examples/misc_charts/charts/Sales_Calendar_Heatmap.yaml: ########## @@ -0,0 +1,47 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See the NOTICE file +# distributed with this work for additional information +# regarding copyright ownership. The ASF licenses this file +# to you under the Apache License, Version 2.0 (the +# "License"); you may not use this file except in compliance +# with the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, +# software distributed under the License is distributed on an +# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +# KIND, either express or implied. See the License for the +# specific language governing permissions and limitations +# under the License. +cache_timeout: null +certification_details: null +certified_by: null +dataset_uuid: e8623bb9-5e00-f531-506a-19607f5f8005 +description: Daily sales intensity across a year, one cell per day. +params: + cell_padding: 2 + cell_radius: 0 + cell_size: 12 + domain_granularity: month + granularity_sqla: order_date + metrics: + - aggregate: SUM + column: + column_name: sales + expressionType: SIMPLE + label: SUM(sales) + optionName: metric_sales_calendar + show_legend: true + show_metric_name: true + show_values: false + steps: 10 + subdomain_granularity: day + time_range: '2004-01-01 : 2005-01-01' + viz_type: cal_heatmap + x_axis_time_format: smart_date +query_context: null +slice_name: Sales Calendar Heatmap +uuid: ef13dcad-c918-4367-ab17-a31d56e770e0 +version: 1.0.0 +viz_type: cal_heatmap Review Comment: <!-- Bito Reply --> The reviewer's suggestion to remove the `viz_type` field from `params` is based on a misunderstanding of the chart YAML schema. As you noted, the standard chart export schema requires `viz_type` to be present both as a top-level key and within the `params` object. Since this is the expected structure for chart definitions, the current implementation is correct and should be maintained. ########## superset/examples/deckgl_demo/charts/Deck.gl_Hexagons.yaml: ########## @@ -48,8 +49,8 @@ params: bearing: -2.3984797349335167 latitude: 37.789795085160335 longitude: -122.40632230075536 - pitch: 54.08961642447763 - zoom: 13.835465702403654 + pitch: 50 + zoom: 13.6 Review Comment: <!-- Bito Reply --> The suggestion to align viewport values with the storybook defaults is intended to ensure consistency for users referencing both sources. Since these are example charts and you have determined that the rounded values are preferred for this specific view, you are not required to apply the suggestion. You may choose to ignore it if the current values better serve the purpose of the example. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
