EvanGruhlkey opened a new pull request, #42880:
URL: https://github.com/apache/superset/pull/42880

   ### SUMMARY
   
   Apply a selected percentage-style D3 number format to pie chart percentages 
instead of always using the hardcoded two-decimal formatter. Non-percentage 
number formats retain the existing percentage formatting behavior.
   
   This affects percentage values rendered in pie labels, templates, tooltips, 
and grouped "Other" tooltip rows.
   
   ### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
   
   Not included. This is a formatting-only change covered by focused unit tests.
   
   ### TESTING INSTRUCTIONS
   
   1. Create a pie chart and select a label type that displays percentages.
   2. Set **Number format** to a percentage-style D3 format such as `.1%`.
   3. Confirm percentages in labels and tooltips use one decimal place.
   4. Set **Number format** to a non-percentage format and confirm percentages 
retain the default two-decimal format.
   
   Automated checks:
   
   - `npx jest --silent --runInBand 
plugins/plugin-chart-echarts/test/Pie/transformProps.test.ts`
   - `npx oxfmt --check plugins/plugin-chart-echarts/src/Pie/transformProps.ts 
plugins/plugin-chart-echarts/test/Pie/transformProps.test.ts`
   - `npx oxlint --config oxlint.json --quiet 
plugins/plugin-chart-echarts/src/Pie/transformProps.ts 
plugins/plugin-chart-echarts/test/Pie/transformProps.test.ts`
   
   ### ADDITIONAL INFORMATION
   
   - [x] Has associated issue: Fixes #42834
   - [ ] Required feature flags:
   - [x] Changes UI
   - [ ] Includes DB Migration (follow approval process in 
[SIP-59](https://github.com/apache/superset/issues/13351))
     - [ ] Migration is atomic, supports rollback & is backwards-compatible
     - [ ] Confirm DB migration upgrade and downgrade tested
     - [ ] Runtime estimates and downtime expectations provided
   - [ ] Introduces new feature or API
   - [ ] Removes existing feature or API
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to