vjymisal0 commented on PR #42882: URL: https://github.com/apache/superset/pull/42882#issuecomment-5213672442
Good catch — pushed a fix. Changed `numericValue > 0` to `numericValue !== 0`: the strictly-positive check also suppressed a genuine negative value whenever it cleared a (possibly also negative) threshold, for a category whose stacked total is itself negative. The zero-height overlap bug is specifically about a value of exactly 0, not about sign. Added a regression test for the negative case. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
