vjymisal0 commented on code in PR #42882:
URL: https://github.com/apache/superset/pull/42882#discussion_r3736661322
##########
superset-frontend/plugins/plugin-chart-echarts/src/Timeseries/transformers.ts:
##########
@@ -467,9 +467,17 @@ export function transformSeries(
return formatter(numericValue);
}
if (!onlyTotal) {
+ // A zero-height stacked segment has no meaningful position to
+ // attach a label to: it starts and ends at the same y-coordinate
+ // as the top of the previous segment, so its label would render
+ // directly on top of that segment's own label. Requiring a
+ // strictly positive value keeps this independent of the
+ // configured percentage threshold, whose default of 0 would
+ // otherwise let a value of exactly 0 pass (#42702).
if (
+ numericValue > 0 &&
numericValue >=
- (thresholdValues[dataIndex] || Number.MIN_SAFE_INTEGER)
+ (thresholdValues[dataIndex] || Number.MIN_SAFE_INTEGER)
Review Comment:
Fixed in 26a1ab9 — changed the guard from numericValue > 0 to numericValue
!== 0 so negative values are no longer suppressed, and added a regression test.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
