bito-code-review[bot] commented on code in PR #42309: URL: https://github.com/apache/superset/pull/42309#discussion_r3737009234
########## superset-frontend/plugins/plugin-chart-country-map/src/countries.ts: ########## @@ -103,6 +103,7 @@ import iran from './countries/iran.geojson'; import israel from './countries/israel.geojson'; import italy from './countries/italy.geojson'; import italy_regions from './countries/italy_regions.geojson'; +import italy_regions_and_autonomous_provinces from './countries/italy_regions_and_autonomous_provinces.geojson'; Review Comment: <div> <div id="suggestion"> <div id="issue"><b>Missing test coverage for new country option</b></div> <div id="fix"> The new import and corresponding entry in `countryOptions` at lines 435-437 lacks test coverage. Similar entries like `italy_regions` and `france_regions` also have no dedicated tests. Adding tests for `countryOptions` generation ensures the display labels render correctly for all country variants. This aligns with the existing test structure in the plugin (e.g., `index.test.ts`, `buildQuery.test.ts`). </div> </div> <small><i>Code Review Run #60d612</i></small> </div> --- Should Bito avoid suggestions like this for future reviews? (<a href=https://alpha.bito.ai/home/ai-agents/review-rules>Manage Rules</a>) - [ ] Yes, avoid them -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
