rusackas commented on code in PR #42309: URL: https://github.com/apache/superset/pull/42309#discussion_r3737253739
########## superset-frontend/plugins/plugin-chart-country-map/src/countries.ts: ########## @@ -103,6 +103,7 @@ import iran from './countries/iran.geojson'; import israel from './countries/israel.geojson'; import italy from './countries/italy.geojson'; import italy_regions from './countries/italy_regions.geojson'; +import italy_regions_and_autonomous_provinces from './countries/italy_regions_and_autonomous_provinces.geojson'; Review Comment: Added a small test covering the `countryOptions` label for `italy_regions_and_autonomous_provinces` (and `italy_regions` while at it). Left the rest of the untested country entries alone, thats a bigger pre-existing gap outside this PR. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
