rusackas commented on PR #36350:
URL: https://github.com/apache/superset/pull/36350#issuecomment-5224444767

   Thanks for picking this back up, @X-arshiya-X!
   
   In `superset/explorables/base.py` you're importing `Query` from 
`superset.migrations.shared.catalogs`, not `superset.models.sql_lab` like 
everywhere else in this diff. That's a different, migration-only model class, 
and unlike the other type-only imports in that file it's not guarded by 
`TYPE_CHECKING`, so it drags migration/alembic code into a core runtime module 
on every import. Looks like a stray autocomplete grabbed the wrong `Query`.
   
   Also still shows conflicts with `master`, so it'll need a rebase on top of 
the import fix. Holler if you want help addressing either item.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to