rusackas commented on PR #39257: URL: https://github.com/apache/superset/pull/39257#issuecomment-5243893497
Thanks for the work here! One thing before this can merge, though: the Metrics tab still has the inline `maxWidth: '240px'` on the expression cell, so the wider SQL editor doesn't actually apply there, only Columns and Calculated Columns get it. Codeant already flagged this and it's still open. There's also a pile of unresolved bot threads worth a pass (checkbox typing widened to `unknown`, the stale `initialValue` on the SQL editors, resizable min-width getting dropped) if you don't mind assessing/addressing/resolving those before we take another look. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
