bito-code-review[bot] commented on code in PR #43053:
URL: https://github.com/apache/superset/pull/43053#discussion_r3756013899
##########
superset-frontend/packages/superset-ui-core/src/chart/components/Matrixify/MatrixifyGridCell.test.tsx:
##########
@@ -210,3 +300,170 @@ test('should handle empty cell data gracefully', () => {
// Should still render but with empty title
expect(screen.getByText('SuperChart Mock')).toBeInTheDocument();
});
+
+test('renders chart eagerly when virtualization is disabled', () => {
+ renderWithTheme(<MatrixifyGridCell {...defaultProps} />);
+
+ expect(screen.getByText('SuperChart Mock')).toBeInTheDocument();
+ expect(
+ screen.queryByTestId('matrixify-cell-placeholder'),
Review Comment:
<div>
<div id="suggestion">
<div id="issue"><b>data-testid attribute mismatch</b></div>
<div id="fix">
The placeholder element at line 265 uses
`data-test="matrixify-cell-placeholder"` but all new tests use
`screen.getByTestId('matrixify-cell-placeholder')` which looks for
`data-testid`. This mismatch will cause every virtualization-related test to
fail with: `TestingLibraryElementError: Unable to find an accessible element
with the test-id: 'matrixify-cell-placeholder'`. Fix: change `data-test` to
`data-testid` on the `ChartPlaceholder` component in MatrixifyGridCell.tsx:265.
</div>
</div>
<small><i>Code Review Run #637bb7</i></small>
</div>
---
Should Bito avoid suggestions like this for future reviews? (<a
href=https://alpha.bito.ai/home/ai-agents/review-rules>Manage Rules</a>)
- [ ] Yes, avoid them
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
