jenwitteng commented on code in PR #43053:
URL: https://github.com/apache/superset/pull/43053#discussion_r3756452583
##########
superset-frontend/packages/superset-ui-core/src/chart/components/Matrixify/MatrixifyGridCell.test.tsx:
##########
@@ -210,3 +300,170 @@ test('should handle empty cell data gracefully', () => {
// Should still render but with empty title
expect(screen.getByText('SuperChart Mock')).toBeInTheDocument();
});
+
+test('renders chart eagerly when virtualization is disabled', () => {
+ renderWithTheme(<MatrixifyGridCell {...defaultProps} />);
+
+ expect(screen.getByText('SuperChart Mock')).toBeInTheDocument();
+ expect(
+ screen.queryByTestId('matrixify-cell-placeholder'),
Review Comment:
This is a false positive: this repo globally remaps RTL's testIdAttribute to
'data-test'
(spec/helpers/setup.ts), which is exactly why StatefulChart.test.tsx uses
the same data-test convention elsewhere.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
