SEPURI-SAI-KRISHNA commented on PR #43203: URL: https://github.com/apache/superset/pull/43203#issuecomment-5300928127
The suggested change isn't applicable, contribution_totals is a dict[str, float] parameter, not a callable, so totals = contribution_totals(contribution_df, numeric_df, columns, orientation) would raise TypeError: 'dict' object is not callable. On the substance, this overlaps the inline thread on contribution.py: the totals builder at query_context_processor.py:446 filters on dtype.kind in "biufc" and so omits object-dtype Decimal columns. That is real but pre-existing, the previous select_dtypes(include=["number", Decimal]) resolved Decimal to object and selected the same columns, so the set reaching the totals path is unchanged by this PR. Tracking it as a follow-up against the totals builder. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
