SEPURI-SAI-KRISHNA commented on PR #43203: URL: https://github.com/apache/superset/pull/43203#issuecomment-5351631444
Follow-up on the `contribution_totals` gap codeant-ai raised in review: opened as #43222, which teaches the totals builder to include object-dtype Decimal columns through an `_is_summable` helper, so the lookup stops returning `None` for them and assigning zero. Keeping the two separate on purpose: this PR decides which columns `contribution()` operates on, #43222 decides which columns get a total. The zero-assignment described in that thread needs both to land. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
