s1ny1998 commented on PR #43000: URL: https://github.com/apache/superset/pull/43000#issuecomment-5325234328
Hi @joe-clickhouse, Thanks for taking the time to review the PR. I've made the requested changes and tested them locally as well. I had a couple of questions: 1. Should we use Decimal instead of Float64? Is there a preference from a query performance or precision perspective? 2. If the connected ClickHouse cluster has replication enabled, we'd need to use ReplicatedMergeTree instead of MergeTree. Should we handle that case as well? I was thinking of checking system.replicas or system.zookeeper to detect whether replication is enabled. However, that would require the ClickHouse user provided during database setup to have permissions to query those system tables. Does that seem like the right approach, or would you prefer a different way of handling it? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
