s1ny1998 commented on PR #43000: URL: https://github.com/apache/superset/pull/43000#issuecomment-5325288667
Note : **4. `clickhouse_engine=` vs. positional `MergeTree`.** This one dissolved rather than got fixed: no SQLAlchemy `Table` is constructed any more, and the DDL is issued directly as `CREATE TABLE ... ENGINE = MergeTree ORDER BY tuple()` through `client.command`. clickhouse-connect's DDL classes are no longer imported at all, so there's no clash with clickhouse-sqlalchemy owning the `clickhouse` keyword namespace, and nothing here needs a version beyond the advertised `>=0.13.0`. Identifiers are backtick-quoted with embedded backticks doubled. point 4 is framed as "dissolved" rather than "fixed" because the rewrite removed the MergeTree import entirely. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
