bito-code-review[bot] commented on PR #43349:
URL: https://github.com/apache/superset/pull/43349#issuecomment-5349146217
<!-- Bito Reply -->
The flagged issue is correct. Using `effective_force` (which includes `not
request.use_cache`) to populate the `refreshed` field in `cache_status`
incorrectly signals an explicit refresh even when the user only intended to
bypass the cache. To resolve this, you should pass `request.force_refresh`
directly to `get_cache_status_from_result` while continuing to use
`effective_force` for the actual query execution.
Would you like me to fetch all other comments on this PR to validate and
implement fixes for them as well?
**superset/mcp_service/chart/tool/get_chart_data.py**
```
# Cache status information using utility function
cache_status = get_cache_status_from_result(
query_result, force_refresh=request.force_refresh
)
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
