justinpark commented on code in PR #43349:
URL: https://github.com/apache/superset/pull/43349#discussion_r3823575498
##########
superset/mcp_service/chart/tool/get_chart_data.py:
##########
@@ -1117,7 +1126,7 @@ async def _query_from_form_data(
)
cache_status = get_cache_status_from_result(
- query_result, force_refresh=request.force_refresh
+ query_result, force_refresh=effective_force
)
Review Comment:
Fixed in commit 3d208df19c — `get_cache_status_from_result(...)` now passes
`request.force_refresh` (not `effective_force`) at both call sites (lines
806-807 and 1128-1129), so `cache_status.refreshed` reflects only an explicit
force refresh. `effective_force` is still used for query execution (cache
bypass). Resolving.
##########
superset/mcp_service/chart/tool/get_chart_data.py:
##########
@@ -1117,7 +1126,7 @@ async def _query_from_form_data(
)
cache_status = get_cache_status_from_result(
- query_result, force_refresh=request.force_refresh
+ query_result, force_refresh=effective_force
)
Review Comment:
resolved
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
