bito-code-review[bot] commented on PR #43350:
URL: https://github.com/apache/superset/pull/43350#issuecomment-5349314014
<!-- Bito Reply -->
The flagged issue is correct. The current implementation calculates
normalization metadata using `getFormDataFromControls` during hydration, but
the save payload uses `explore.form_data` directly. This discrepancy causes the
backend to reject entries as stale because the values do not match.
To resolve this, you should ensure the metadata is built from the same
form-data representation used in the save payload. The PR already implements
this by calculating `hydratedFormData` using `getFormDataFromControls` and then
using that for normalization transitions, which aligns with the save logic.
I have reviewed the changes and they correctly address the identified API
mismatch by ensuring consistency between the hydration normalization tracking
and the save payload generation.
**superset-frontend/src/explore/actions/hydrateExplore.ts**
```
const hydratedFormData = {
...initialFormData,
...getFormDataFromControls(exploreState.controls),
};
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
